Skip to content

Conversation

perseoGI
Copy link
Contributor

@perseoGI perseoGI commented Sep 8, 2025

Summary

Changes to recipe: clickhouse-cpp/2.5.1

Motivation

While compiling userver, clickhouse-cpp arises with the known CMake 4 incompatibility.
This PR aims to fix this issue by setting CMAKE_POLICY_VERSION_MINIMUM and also, remove old versions not in use by CCI.

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good simplification

@perseoGI
Copy link
Contributor Author

Succesfull compilation logs using different versions of abseil as it is known for being tricky:

  • abseil/20250127.0 (last one)
======== Testing the package: Executing test ========
clickhouse-cpp/2.5.1 (test package): Running test()
clickhouse-cpp/2.5.1 (test package): RUN: ./test_package
not connected but works
  • abseil/20240722.1
======== Testing the package: Executing test ========
clickhouse-cpp/2.5.1 (test package): Running test()
clickhouse-cpp/2.5.1 (test package): RUN: ./test_package
not connected but works
  • abseil/20240116.2
======== Testing the package: Executing test ========
clickhouse-cpp/2.5.1 (test package): Running test()
clickhouse-cpp/2.5.1 (test package): RUN: ./test_package
not connected but works
  • abseil/20240722.1 (oldest one)
======== Testing the package: Executing test ========
clickhouse-cpp/2.5.1 (test package): Running test()
clickhouse-cpp/2.5.1 (test package): RUN: ./test_package
not connected but works

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@franramirez688 franramirez688 merged commit 745473c into conan-io:master Sep 15, 2025
10 checks passed
@franramirez688 franramirez688 changed the title clickhouse-cpp: CMake 4 support and pruned old versions clickhouse-cpp: CMake 4 support and stop publishing revisions for older versions Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants