Skip to content

Conversation

mheon
Copy link
Member

@mheon mheon commented Sep 11, 2025

A summary of our intentions with regards to a replacement of Conmon

Does this PR introduce a user-facing change?

NONE

Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
These should be E2E tests.
Once a comprehensive test suite exists, we can use it to test both legacy Conmon and Conmon v3.

In addition to these E2E tests, we can add unit tests to critical functionality in the Rust code as it is written.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to state the obvious all existing podman tests in the podman repo should pass as well with the new conmon.

@Honny1
Copy link
Member

Honny1 commented Sep 12, 2025

We should also consider executing Healthchecks with ConmonV3, which would allow them to run on non-systemd systems.

ref: #27033

@Luap99
Copy link
Member

Luap99 commented Sep 12, 2025

We should also consider executing Healthchecks with ConmonV3, which would allow them to run on non-systemd systems.

ref: #27033

I would consider this out of scope for the initial work here though I like the idea.

@mheon
Copy link
Member Author

mheon commented Sep 12, 2025

I'll put it in the doc so we don't forget, but I agree it's out of scope for initial version - let's get it done, then start adding

@Honny1
Copy link
Member

Honny1 commented Sep 12, 2025

Sure, it's out of scope for the MVP, but I don't want this to be forgotten.

@jankaluza
Copy link
Member

The doc looks good. I think it clearly summarizes what we are trying to achieve and also how.

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Matt Heon <mheon@redhat.com>
@mheon mheon force-pushed the design_doc_conmon3 branch from d386add to 9bca0d0 Compare September 25, 2025 19:54
@baude
Copy link
Member

baude commented Sep 25, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f8f6248 into containers:main Sep 25, 2025
33 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants