Skip to content

Conversation

neurolag
Copy link

Does this PR introduce a user-facing change?

None

Adjust commands in `podman-for-windows` guide

In more recent Windows 11 versions (not sure about Windows 10),
Windows now ships its own `curl.exe`,
so PowerShell's "curl"-alias no longer exists.

Changes made in this commit will replace the `curl` alias call with the actual `Invoke-WebRequest` function.

Signed-off-by: Manuel Thalmann <m@nuth.ch>
Changes made in this commit will fix containers#16168

The current command in the docs expect a `docker.exe` file to exist in the current working directory.
As this is most likely a typo, changes made in this commit fix this issue.

Signed-off-by: Manuel Thalmann <m@nuth.ch>
Copy link
Contributor

openshift-ci bot commented Sep 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neurolag
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop the [skip-ci] prefix from your commit messages. Stuff like this should never skip CI as basic validation such as spell checkers, formatters, etc... still run.

And also it would need to be part of the PR description to have nay effect, cirrus ci won't take the commit title into account so it didn't work anyway,

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the points that @Luap99 raised, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants