-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add tmt integration plan #27140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tmt integration plan #27140
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LecrisUT The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See: - teemtee/tmt#4047 - teemtee/tmt#4026 Signed-off-by: Cristian Le <git@lecris.dev>
d1ad4f6
to
8be8e74
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
3 similar comments
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
@LecrisUT change itself looks good, but over here it would be preferable to add a separate set of jobs in .packit.yaml and have some github IDs included in failure notifications, like what's done for cockpit revdep tests. @containers/podman-maintainers PTAL, wdyt? This is another set of revdep tests, this time for TMT project itself. |
I'd say no need to include podman-next repo in the additional job if it keeps things simpler for now. We're already catching crun and container-selinux issues in those projects. |
Signed-off-by: Cristian Le <git@lecris.dev>
packages: [podman-fedora] | ||
notifications: | ||
failure_comment: | ||
message: "tmt tests failed for commit {commit_sha}. @lsm5, @psss please check." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsm5 someone better to ping for these. avc
stuff would be hard for us to decipher, but not sure if those are the time of failures expected there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fall under the same rules as the cockpit tests, packit is non blocking for us so we won't gate merges on this and most maintainers will not lock at these failures as they fail to often for unrelated reasons. |
See:
podman
friends integration plan in relevant repos teemtee/tmt#4047An alternative design is to add the tests in
.packit.yaml
. Let me know which approach would be preferred. I don't quite follow the steps you do withpodman-next*.repo
, maybe we could look into that as well?(should use only one PR where we discuss and test these)