Skip to content

Conversation

LecrisUT
Copy link

See:

An alternative design is to add the tests in .packit.yaml. Let me know which approach would be preferred. I don't quite follow the steps you do with podman-next*.repo, maybe we could look into that as well?

(should use only one PR where we discuss and test these)

Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 22, 2025
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LecrisUT
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

See:
- teemtee/tmt#4047
- teemtee/tmt#4026

Signed-off-by: Cristian Le <git@lecris.dev>
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

3 similar comments
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 added No New Tests Allow PR to proceed without adding regression tests and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 23, 2025
@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

@LecrisUT change itself looks good, but over here it would be preferable to add a separate set of jobs in .packit.yaml and have some github IDs included in failure notifications, like what's done for cockpit revdep tests.

@containers/podman-maintainers PTAL, wdyt? This is another set of revdep tests, this time for TMT project itself.

@lsm5
Copy link
Member

lsm5 commented Sep 23, 2025

@LecrisUT change itself looks good, but over here it would be preferable to add a separate set of jobs in .packit.yaml and have some github IDs included in failure notifications, like what's done for cockpit revdep tests.

I'd say no need to include podman-next repo in the additional job if it keeps things simpler for now. We're already catching crun and container-selinux issues in those projects.

Signed-off-by: Cristian Le <git@lecris.dev>
packages: [podman-fedora]
notifications:
failure_comment:
message: "tmt tests failed for commit {commit_sha}. @lsm5, @psss please check."
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsm5 someone better to ping for these. avc stuff would be hard for us to decipher, but not sure if those are the time of failures expected there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me if it works for @psss . Does @thrix wanna be included here?

@Luap99
Copy link
Member

Luap99 commented Sep 30, 2025

This would fall under the same rules as the cockpit tests, packit is non blocking for us so we won't gate merges on this and most maintainers will not lock at these failures as they fail to often for unrelated reasons.
As such it is up to you (or @psss I guess as you added his ping to the failure message) to react on the ping and tell the author/maintainers that this PR is actually breaking something for tmt usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants