-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Added virtual size option in artifact ls format #27159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added virtual size option in artifact ls format #27159
Conversation
Signed-off-by: Celso Henrique Souza Silva <celsohenrique367@gmail.com>
I did not add tests because this test file already cover all commands with flag --format. podman/test/system/610-format.bats Lines 25 to 29 in d58e496
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Unfortunately, you will need to implement a part of the test yourself, such as creating an artifact. The function you found is a helper, which is called from this test: podman/test/system/610-format.bats Line 122 in d58e496
I am okay with extending the current test to include the creation of an artifact, etc. |
8ba53d3
to
5ae0e0d
Compare
Signed-off-by: Celso Henrique Souza Silva <celsohenrique367@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. The failed CI test looks like a flake. Please retrigger it here: https://cirrus-ci.com/task/6296539838021632. As the PR author, you have permission to do so.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, nothiaki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this PR introduce a user-facing change?
Yes, added the option to format the list showing the virtual size
podman artifact ls --format '{{ .VirtualSize }}'
Closes #27085