-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[compat api] Remove ContainerConfig field #27172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compat api] Remove ContainerConfig field #27172
Conversation
45e2a1b
to
431202b
Compare
The way we handle the API docs makes it hard to correctly handle the compate API removals as users can't browse our API docs using docker version numbers. I'm not sure what I should do, I can just make Container and ContainerConfig no longer show in the response json in the swagger docs? |
431202b
to
b0e85ea
Compare
Maybe this is a clean way: https://github.com/containers/podman/pull/27172/files#diff-591d6e4a5c080b38e1948fdf4ba7a35448f9d3845ef018c89a47eefadc7bf0adR26-R28 |
b0e85ea
to
7eeb35a
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
217cbd3
to
a28b0a2
Compare
ContainerConfig has been removed from v1.45 InspectResponse.Container has also been removed but it seems we never implemented it. Ref: https://docs.docker.com/reference/api/engine/version-history/#v145-api-changes Signed-off-by: Lewis Roy <lewis@redhat.com>
a28b0a2
to
5718667
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, ninja-quokka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ContainerConfig has been removed from v1.45
InspectResponse.Container has also been removed but it seems we never implemented it.
Ref: https://docs.docker.com/reference/api/engine/version-history/#v145-api-changes
Does this PR introduce a user-facing change?