Skip to content

Conversation

ninja-quokka
Copy link
Collaborator

ContainerConfig has been removed from v1.45

InspectResponse.Container has also been removed but it seems we never implemented it.

Ref: https://docs.docker.com/reference/api/engine/version-history/#v145-api-changes

Does this PR introduce a user-facing change?

GET /images/{name}/json no longer includes the ContainerConfig fields. To access image configuration, use Config field instead.

@ninja-quokka ninja-quokka requested a review from inknos September 27, 2025 03:28
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Sep 27, 2025
@ninja-quokka
Copy link
Collaborator Author

The way we handle the API docs makes it hard to correctly handle the compate API removals as users can't browse our API docs using docker version numbers.

I'm not sure what I should do, I can just make Container and ContainerConfig no longer show in the response json in the swagger docs?

@ninja-quokka
Copy link
Collaborator Author

The way we handle the API docs makes it hard to correctly handle the compate API removals as users can't browse our API docs using docker version numbers.

I'm not sure what I should do, I can just make Container and ContainerConfig no longer show in the response json in the swagger docs?

Maybe this is a clean way: https://github.com/containers/podman/pull/27172/files#diff-591d6e4a5c080b38e1948fdf4ba7a35448f9d3845ef018c89a47eefadc7bf0adR26-R28

Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@ninja-quokka ninja-quokka force-pushed the docker_compate_145 branch 2 times, most recently from 217cbd3 to a28b0a2 Compare September 27, 2025 10:44
ContainerConfig has been removed from v1.45

InspectResponse.Container has also been removed but it seems we never implemented it.

Ref: https://docs.docker.com/reference/api/engine/version-history/#v145-api-changes
Signed-off-by: Lewis Roy <lewis@redhat.com>
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@inknos
Copy link
Collaborator

inknos commented Sep 29, 2025

LGTM

Copy link
Member

@baude baude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, ninja-quokka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e57a7f3 into containers:main Sep 29, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants