Skip to content

Conversation

tylerpina
Copy link
Contributor

@tylerpina tylerpina commented Sep 23, 2025

https://contentful.atlassian.net/browse/DX-408

Summary

This PR introduces new tooling that handles taxonomy concept operations

PR Checklist

  • I have read the CONTRIBUTING.md file
  • All commits follow conventional commits
  • Documentation is updated (if necessary)
  • PR doesn't contain any sensitive information
  • There are no breaking changes

@tylerpina tylerpina requested a review from a team as a code owner September 23, 2025 19:12
@tylerpina tylerpina changed the title feat: taxonomy concept tools [DX-409] feat: taxonomy concept tools [DX-408] Sep 23, 2025

async function tool(args: Params) {
const contentfulClient = createToolClient({
spaceId: 'dummy', // Not needed for concept deletion but required by BaseToolSchema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way we could write this for this tool? Maybe not use the base tool schema or create a new tool schema so we don't require this params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This dummy client was also used in some of the scheme tools, so I went ahead and updated those as well. Sorry for ballooning this PR😅


async function tool(args: Params) {
const contentfulClient = createToolClient({
spaceId: 'dummy', // Not needed for concept operations but required by BaseToolSchema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above comment

Copy link
Collaborator

@chasepoirier chasepoirier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just noticed that it looks like these tools would benefit from a new base tool schema so that spaceId and environmentId weren't required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants