-
Notifications
You must be signed in to change notification settings - Fork 8
feat: taxonomy concept tools [DX-408] #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
async function tool(args: Params) { | ||
const contentfulClient = createToolClient({ | ||
spaceId: 'dummy', // Not needed for concept deletion but required by BaseToolSchema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way we could write this for this tool? Maybe not use the base tool schema or create a new tool schema so we don't require this params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. This dummy client was also used in some of the scheme tools, so I went ahead and updated those as well. Sorry for ballooning this PR😅
|
||
async function tool(args: Params) { | ||
const contentfulClient = createToolClient({ | ||
spaceId: 'dummy', // Not needed for concept operations but required by BaseToolSchema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just noticed that it looks like these tools would benefit from a new base tool schema so that spaceId and environmentId weren't required.
https://contentful.atlassian.net/browse/DX-408
Summary
This PR introduces new tooling that handles taxonomy concept operations
PR Checklist
CONTRIBUTING.md
file