feat: Add TOTP/MFA support for login #183
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reeshika-h
commented
Sep 15, 2025
reeshika-h
commented
- Added TOTP/MFA support for login
- Unit testcases also added
- Simplified login method to handle TOTP and MFA secret. - Added input validation for email, password, and TOTP token. - Updated User class to implement generic BaseImplementation. - Introduced unit tests for login scenarios including TOTP and MFA handling.
…tion - Updated login method to accept a map of parameters for TOTP and MFA secret.
cs-raj
previously approved these changes
Sep 17, 2025
cs-raj
previously approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.