Skip to content

fix: variants type naming fix #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: variants type naming fix #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/typescript/variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { expect } from "chai"
import path from "path"
import { Stack } from "../../types/stack";
import { Variant, Variants } from "../../types/stack/VariantGroup/variants";
import { variantEntry, variantEntry2 } from "./mock/variants";
var tokenUID = ''
export function createVariant(stack: Stack) {
Expand Down
4 changes: 2 additions & 2 deletions types/stack/VariantGroup/variants/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { AnyProperty, SystemFields } from "../../../utility/fields";
import { Queryable, SystemFunction } from "../../../utility/operations";

export interface Variant extends SystemFields, SystemFunction<Variants> {
export interface VariantGroupVariant extends SystemFields, SystemFunction<VariantGroupVariants> {

}

export interface Variants extends Queryable<Variants, {variant: VariantData}> {
export interface VariantGroupVariants extends Queryable<VariantGroupVariants, {variant: VariantData}> {

}

Expand Down
6 changes: 3 additions & 3 deletions types/stack/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { Taxonomy, Taxonomies } from "./taxonomy";
import { ManagementToken, ManagementTokens } from "./managementToken";
import { Variant, Variants } from "./variants";
import { VariantGroup, VariantGroups } from "./VariantGroup";
import { Variant, Variants } from "./VariantGroup/variants";
import { VariantGroupVariant, VariantGroupVariants } from "./VariantGroup/variants";

export interface StackConfig {
api_key:string
Expand Down Expand Up @@ -110,6 +110,6 @@ export interface Stack extends SystemFields {
variantGroup(): VariantGroups
variantGroup(uid: string): VariantGroup

variant(): Variants
variant(uid: string): Variant
variant(): VariantGroupVariants
variant(uid: string): VariantGroupVariant
}
Loading