Skip to content

fix(vcs): git checkout after clone must contains -- . #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vcs): git checkout after clone must contains -- . #2151

wants to merge 1 commit into from

Conversation

kamontat
Copy link

@kamontat kamontat commented May 16, 2025 •
edited
Loading

Without -- . on the end cause git to not checkout latest changes from .git directory.

CleanShot 2025-05-16 at 16 27 55@2x

[fixes #1887]

sisp
sisp requested changes May 16, 2025
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug, @kamontat ! 🙏 Would you mind adding a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisp sisp sisp requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copier copy didn't copy my uncommit file even though I added -r HEAD option
2 participants
@kamontat @sisp