fix: use video view for correct screencap framing #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calebboyd Nice \o/ |
|
That funny it was already fixed here https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/427/files#diff-d70c63d9377ee3067943b8ec4cf9fda5R345 saw that when i merged master. RTCMTLVideoView support should improve performance if you want to try it @calebboyd |
|
Hmm I tried #427 and it captured the wrong height/width again... |
|
Arf I will compare again, may be I fucked the merge |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image captured was the dimension of the container element and not the video element.