dbus: add GetUnitFileState method #350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekto0n
reviewed
Dec 15, 2020
lucab
suggested changes
Dec 15, 2020
|
@vaspahomov thanks for your patch. I've left a few comments in review, and it would be good to have a test for this too. |
vaspahomov
force-pushed
the
feature/add-GetUnitFileState-method
branch
2 times, most recently
from
586b8f6 to
3ef922d
Compare
vaspahomov
force-pushed
the
feature/add-GetUnitFileState-method
branch
from
3ef922d to
db69fcc
Compare
lucab
suggested changes
Feb 23, 2021
| func TestGetUnitFileState(t *testing.T) { | ||
| conn := setupConn(t) | ||
| defer conn.Close() | ||
| service := "systemd-udevd.service" |
There was a problem hiding this comment.
This may not exist in the testing environment. It would be good to set up a dedicated temporary service unit instead.
|
Can you please resolve conflicts so @lucab can merge it? |
|
looking to call this method (GetUnitFileState) but it's just stale. Is there another way? |
kolyshkin
reviewed
Sep 16, 2025
| return status, nil | ||
| } | ||
|
|
||
| // GetUnitFileStateContext returns UnitFileState |
There was a problem hiding this comment.
- You don't have to add
Contextto the method name -- all new methods accept context. - What is
UnitFileStateand where it is defined?
kolyshkin
reviewed
Sep 16, 2025
|
|
||
| // GetUnitFileStateContext returns UnitFileState | ||
| func (c *Conn) GetUnitFileStateContext(ctx context.Context, name string) (string, error) { | ||
| var prop dbus.Variant |
There was a problem hiding this comment.
Can you just use string here?
|
@vaspahomov please let us know if you want to keep working on this (and I apologize for a late response). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.