enable 'no-unsafe-call' lint #1905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| declare const window: any; | ||
| declare const document: any; | ||
| const getElement = (id: string): HTMLInputElement => { | ||
| const e = document.getElementById(id); |
Member
There was a problem hiding this comment.
Does this compile? How does TS know document.getElementById exists here?
Member
There was a problem hiding this comment.
Nevermind, in ledger-amino we have DOM types due to
"lib": ["es2020", "dom"]
webmaster128
approved these changes
Nov 12, 2025
Member
webmaster128
left a comment
webmaster128
left a comment
There was a problem hiding this comment.
Thank you.
I will merge this manually to resolve the conflict from renaming cosmwasm-stargate
| return account ? accountFromAny(account) : null; | ||
| } catch (error: any) { | ||
| if (/rpc error: code = NotFound/i.test(error.toString())) { | ||
| if (/rpc error: code = NotFound/i.test(String(error))) { |
Member
There was a problem hiding this comment.
Here we can also use the solution from the other getAccount implementation:
} catch (error) {
assert(error instanceof Error);
if (/rpc error: code = NotFound/i.test(error.toString())) {
return null;
}
It avoids the any type and uses unknown instead. Any preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1750. Most warnings were in the ledger-amino web code.