-
-
Notifications
You must be signed in to change notification settings - Fork 304
Skip re-extract ext-imap source #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
imap still seems to fail, we should probably fix it a last time, but move it into unsupported/deprecated territory. I remember the huge pain in the ass it was to get it working in the first place, no other library was that bad |
That's really weird, I'll have time to look into it next week. 🫠 |
I'll leave the fun of figuring out the swoole segmentation fault to you. Imap now works again. |
02114c0
to
dd72b32
Compare
Seems swoole is using glibc-only feature, but it will not working with extra CFLAGS |
I think we should generate environment info report after building anything. I also encounter this problem when trying to use swoole and spc branches from May 31, although its CI was green 2 months ago. |
Okay, I found the key point. 2025-05-30 released Alpine Linux 3.22, and before it we were using The only difference I found between 3.21 and 3.22 is the gcc version (14.2: And if I add |
Could likely work around it by using -fno-sanitize=address (or =undefined or =thread) like we do with zig, which automatically enables them. I don't run into the issue when doing a static musl or dynamic musl build with zig. |
Oh, on a positive note, all the bugs I've reported are tagged for 15.0 release, so we'll be able to skip the messy zig-cc workaround then. Only the performance one hasn't seen any response. |
I'd rather address the issue since we don't know how long it will take to push 3.0. Otherwise people running the latest version will run into the issue. |
I've made alpine back to 3.21 and created an issue to swoole repo as workaround. From the most direct perspective, the update of alpine broke our build, so it is a better choice to temporarily return to the previous version. I believe the best solution is always to fix the upstream repository, but I'm not sure which approach the swoole maintainers are willing to accept. For us, what we can do now is build it successfully. |
Oh you're right, is this is a general issue then swoole should set the required compilation parameters in their config.m4. |
What does this PR do?
Fix #789 .
Checklist before merging
*.php
or*.json
, run them locally to ensure your changes are valid:PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
composer analyse
composer test
bin/spc dev:sort-config
src/globals/test-extensions.php
.extension test
ortest extensions
to trigger full test suite.