Skip to content

Check lib-suggest before packing libs #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Check lib-suggest before packing libs #802

merged 1 commit into from
Jul 17, 2025

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Check lib-suggest before packing libs. This will prevent packing alternative libs when someone uses different dependency tree.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes June 22, 2025 05:54
@crazywhalecc crazywhalecc added the kind/framework Issues related to CLI app framework label Jun 22, 2025
@crazywhalecc crazywhalecc requested a review from henderkes July 17, 2025 04:27
@crazywhalecc crazywhalecc merged commit bb5eb64 into main Jul 17, 2025
9 checks passed
@crazywhalecc crazywhalecc deleted the feat/safe-pack branch July 17, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/framework Issues related to CLI app framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants