fix: improve SAML signature validation for redirect binding #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for sha1 & sha512 add tests use query sign in redirect implement review feedback - Return error if signature is unsupported - wrap errors Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> Co-authored-by: Orgad Shaneh <orgads@gmail.com>
- Removes the signature validation using SAMLResponse payload for HTTP-Redirect binding - Fix the Signature validation failures for ADFS because of decode/encode while reconstructing the sign data
|
Review please @crewjam @andreas-kupries @Jguer @omerkarj |
|
@crewjam - just wondering if you’ve had a chance to take a look at this PR. I'm happy to help with any changes needed to get it fixed and merged |
|
@crewjam - could you help to review this PR. |
|
any ETA on this ? |
|
@crewjam - could you help to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the merge conflicts in #449
In addition to the changes mentioned in the above PR, it also fixes the following
Tested single logout with Okta and Microsoft Entra ID(Azure AD)