Skip to content
This repository was archived by the owner on Nov 20, 2021. It is now read-only.

Conversation

seaunderwater
Copy link
Contributor

Users of cabpc are currently unable to define pod labels on controlplane components.

Reference:
criticalstack/crit#31
criticalstack/crit#29

@ChrisRx
Copy link
Member

ChrisRx commented Mar 9, 2021

The pod labels should work so long as the version of crit installed on the instance is the newest version and the v1alpha2 configuration is being used. Users will need to use the v1alpha2 configuration to use ExtraLabels. See criticalstack/crit#30 where it was removed from the v1alpha1 configuration (it was added by mistake initially).

@seaunderwater
Copy link
Contributor Author

The pod labels should work so long as the version of crit installed on the instance is the newest version and the v1alpha2 configuration is being used. Users will need to use the v1alpha2 configuration to use ExtraLabels. See criticalstack/crit#30 where it was removed from the v1alpha1 configuration (it was added by mistake initially).

Testing with a v1alpha2 configuration and crit v1.0.9, the ExtraLabels specified do not seem to work. I can troubleshoot further and get back to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants