Skip to content

Conversation

acm-073
Copy link

@acm-073 acm-073 commented Sep 8, 2025

This PR implements #3336
At the moment, only the "PLAIN" SASL mechanism is supported. This is required for example to connect to an Azure EventHub Kafka endpoint.

/kind enhancement
/area local-api

@github-actions github-actions bot added kind/enhancement New feature or request area/local-api labels Sep 8, 2025
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.65%. Comparing base (d25633d) to head (9921780).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3872      +/-   ##
==========================================
+ Coverage   61.61%   61.65%   +0.04%     
==========================================
  Files         406      406              
  Lines       41850    41871      +21     
==========================================
+ Hits        25784    25816      +32     
+ Misses      13936    13929       -7     
+ Partials     2130     2126       -4     
Flag Coverage Δ
bats 45.68% <0.00%> (+0.04%) ⬆️
unit-linux 34.67% <100.00%> (+0.04%) ⬆️
unit-windows 24.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acm-073
Copy link
Author

acm-073 commented Sep 23, 2025

Dear maintainer team,

I understand you're probably overloaded with PRs... but is there any chance this one gets merged in the near future? That would really be great!

Thanks for a short feedback
Albrecht

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements SASL authentication support for Kafka acquisition to enable connections to endpoints like Azure EventHub. The implementation currently supports only the "PLAIN" SASL mechanism as requested in issue #3336.

Key changes:

  • Added SASL configuration structure with mechanism, credentials, and SSL settings
  • Implemented SASL mechanism creation with support for PLAIN authentication
  • Enhanced Kafka dialer to handle SASL authentication and SSL connections

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/acquisition/modules/kafka/kafka.go Added SASL configuration struct, SASL mechanism creation, and enhanced dialer with SASL support
pkg/acquisition/modules/kafka/kafka_test.go Added test cases for valid PLAIN SASL configuration and unsupported SCRAM mechanism

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@acm-073
Copy link
Author

acm-073 commented Oct 1, 2025

@LaurenceJJones I have fixed the review findings from the automated Copilot review... could you maybe have another look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants