-
Notifications
You must be signed in to change notification settings - Fork 539
Add SASL authentication for kafka acquisition #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3872 +/- ##
==========================================
+ Coverage 61.61% 61.65% +0.04%
==========================================
Files 406 406
Lines 41850 41871 +21
==========================================
+ Hits 25784 25816 +32
+ Misses 13936 13929 -7
+ Partials 2130 2126 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dear maintainer team, I understand you're probably overloaded with PRs... but is there any chance this one gets merged in the near future? That would really be great! Thanks for a short feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements SASL authentication support for Kafka acquisition to enable connections to endpoints like Azure EventHub. The implementation currently supports only the "PLAIN" SASL mechanism as requested in issue #3336.
Key changes:
- Added SASL configuration structure with mechanism, credentials, and SSL settings
- Implemented SASL mechanism creation with support for PLAIN authentication
- Enhanced Kafka dialer to handle SASL authentication and SSL connections
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
pkg/acquisition/modules/kafka/kafka.go | Added SASL configuration struct, SASL mechanism creation, and enhanced dialer with SASL support |
pkg/acquisition/modules/kafka/kafka_test.go | Added test cases for valid PLAIN SASL configuration and unsupported SCRAM mechanism |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@LaurenceJJones I have fixed the review findings from the automated Copilot review... could you maybe have another look? Thanks! |
This PR implements #3336
At the moment, only the "PLAIN" SASL mechanism is supported. This is required for example to connect to an Azure EventHub Kafka endpoint.
/kind enhancement
/area local-api