Skip to content

Conversation

@songgaoye
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@songgaoye songgaoye requested a review from a team as a code owner October 28, 2025 11:36
@songgaoye songgaoye requested review from JayT106 and calvinaco and removed request for a team October 28, 2025 11:36
@github-actions

This comment has been minimized.

@songgaoye songgaoye marked this pull request as draft October 28, 2025 11:37
@songgaoye songgaoye force-pushed the song/fix_cache_mutate branch from 8379356 to 093c1f2 Compare November 12, 2025 02:52
@songgaoye songgaoye changed the title fix: tree cache mutate fix(memiavl): tree.Get, tree.set when disable zerocopy Nov 12, 2025
@songgaoye songgaoye marked this pull request as ready for review November 12, 2025 04:46
Copy link

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songgaoye songgaoye changed the title fix(memiavl): tree.Get, tree.set when disable zerocopy fix(memiavl): clone key/values in tree.Get/tree.set when zerocopy is disabled Nov 19, 2025
@songgaoye songgaoye added this pull request to the merge queue Nov 19, 2025
Merged via the queue into master with commit 19a930c Nov 19, 2025
17 checks passed
@songgaoye songgaoye deleted the song/fix_cache_mutate branch November 19, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants