Skip to content

Conversation

@milux
Copy link
Contributor

@milux milux commented Feb 17, 2025

Replaced all occurrences of 'ValidationProfile' with 'ValidationPreset' to better align terminology with its purpose. Updated associated functions, traits, and usage in documentation and CLI arguments accordingly.
Fixes #5.

Replaced all occurrences of 'ValidationProfile' with 'ValidationPreset' to better align terminology with its purpose. Updated associated functions, traits, and usage in documentation and CLI arguments accordingly.
@oxisto oxisto requested a review from tschmidtb51 February 17, 2025 16:12
Copy link
Collaborator

@oxisto oxisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I want to have @tschmidtb51 opinion on this

Copy link

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

oxisto and others added 2 commits February 19, 2025 00:23
Co-authored-by: tschmidtb51 <65305130+tschmidtb51@users.noreply.github.com>
Renamed the `--only-test` option to `--test-id` for clarity and updated its functionality to perform multiple tests. Simplified the main logic by introducing a `process_document` function to handle tests and validation presets for better modularization and readability.
@milux milux requested a review from tschmidtb51 February 24, 2025 15:37
@milux
Copy link
Contributor Author

milux commented Feb 24, 2025

@tschmidtb51 Multiple -t/--test-id options are now supported.

@oxisto oxisto dismissed tschmidtb51’s stale review February 26, 2025 15:47

Changes were implemented

@oxisto oxisto merged commit b159259 into csaf-rs:main Feb 26, 2025
10 checks passed
Copy link

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - forgot to send the "LGTM"

@milux milux deleted the fix/refactor-profile-to-preset branch March 3, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--presets instead of --profiles

3 participants