Skip to content

feat(cubesql): Support BETWEEN SQL push down #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds SQL push down support for [NOT] BETWEEN operator. Related test is included.

@MazterQyou MazterQyou requested review from a team as code owners July 30, 2025 10:26
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 97.15909% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.48%. Comparing base (c2363c4) to head (8543813).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 89.47% 4 Missing ⚠️
.../src/compile/rewrite/rules/wrapper/between_expr.rs 98.80% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9834      +/-   ##
==========================================
+ Coverage   84.46%   84.48%   +0.02%     
==========================================
  Files         249      250       +1     
  Lines       88652    88828     +176     
==========================================
+ Hits        74876    75049     +173     
- Misses      13776    13779       +3     
Flag Coverage Δ
cubesql 84.48% <97.15%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the cubesql/between-sql-push-down branch from 8e92a29 to 8543813 Compare July 30, 2025 16:30
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MazterQyou MazterQyou merged commit 195402f into master Aug 3, 2025
82 checks passed
@MazterQyou MazterQyou deleted the cubesql/between-sql-push-down branch August 3, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants