-
Notifications
You must be signed in to change notification settings - Fork 23
Release v0.8.3 #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.8.3 #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
324 would be nice to have, but it also covers a very limited edge case. I'd maybe give them until tomorrow evening to respond and if there is no response by 20:00 or so, just push 0.8.3 without it (assuming you have time to do that tomorrow).
Getting 0.8.3 out before HA 2025.10.0 is definitely more important than 324.
@sveinse If you are able to edit the release notes after releasing: Compatibility with HA Core 2025.10+ is also a pretty important feature in this release. |
Sure. I'll fix that. I had registered some mention about 2025.10+ but I didn't fully understand why until now. I had to chase a bit to figure out the full story here: We had issue #329, but it refers to PR #326. This one doesn't change anything about the core version. Instead PR #268 implicitly fixes the problem, but doesn't mention HA compatibility. I'm saying to myself right now: You snooze you lose. 😁 |
@steinmn Is the text in the release notes ok now? |
Looks good 👍 Maybe in the future, we can create a next_release.md-document in the repo as a draft for the upcoming release notes? |
...aaaand I just read your comment on #268 (comment) 🤦 You should probably add that too 🤣 |
What the hell. I'm a goldfish 🐟 |
Being spread a little too thin and slipping the details tells me two things: a) here and now fix is much more valuable than "lets remember to note it later", b) A PR puts a record in the git history which is traceable and will make it to the changelog. List of issues is not. So its important to get an explicit PR for something new. "Explicit is better than implicit." Zen of python |
Completely forgot about that one myself, so you're in good company in the aquarium 😛 And in the spirit of not trusting myself to remember this tomorrow: #334 |
Note that this also deletes CHANGELOG.md, which we don't really need when making releases in GitHub