Skip to content

Conversation

sveinse
Copy link
Collaborator

@sveinse sveinse commented Sep 28, 2025

Note that this also deletes CHANGELOG.md, which we don't really need when making releases in GitHub

@sveinse
Copy link
Collaborator Author

sveinse commented Sep 28, 2025

@steinmn Please review. Do you think #324 should be included or not? Unless that PR is complete and ready very soon, I'd say we don't wait. Getting official v0.8.3 out is more critical I think.

Copy link
Contributor

@steinmn steinmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

324 would be nice to have, but it also covers a very limited edge case. I'd maybe give them until tomorrow evening to respond and if there is no response by 20:00 or so, just push 0.8.3 without it (assuming you have time to do that tomorrow).

Getting 0.8.3 out before HA 2025.10.0 is definitely more important than 324.

@sveinse sveinse merged commit 46098ea into custom-components:master Sep 29, 2025
6 checks passed
@sveinse sveinse added this to the v0.8.3 milestone Sep 29, 2025
@sveinse sveinse deleted the feature-release-v0.8.3 branch September 29, 2025 19:36
@steinmn
Copy link
Contributor

steinmn commented Sep 29, 2025

@sveinse If you are able to edit the release notes after releasing: Compatibility with HA Core 2025.10+ is also a pretty important feature in this release.

@sveinse
Copy link
Collaborator Author

sveinse commented Sep 29, 2025

Sure. I'll fix that.

I had registered some mention about 2025.10+ but I didn't fully understand why until now. I had to chase a bit to figure out the full story here: We had issue #329, but it refers to PR #326. This one doesn't change anything about the core version. Instead PR #268 implicitly fixes the problem, but doesn't mention HA compatibility. I'm saying to myself right now: You snooze you lose. 😁

@sveinse
Copy link
Collaborator Author

sveinse commented Sep 29, 2025

@steinmn Is the text in the release notes ok now?

@steinmn
Copy link
Contributor

steinmn commented Sep 29, 2025

Looks good 👍

Maybe in the future, we can create a next_release.md-document in the repo as a draft for the upcoming release notes?

@steinmn
Copy link
Contributor

steinmn commented Sep 29, 2025

...aaaand I just read your comment on #268 (comment) 🤦 You should probably add that too 🤣

@sveinse
Copy link
Collaborator Author

sveinse commented Sep 29, 2025

What the hell. I'm a goldfish 🐟

@sveinse
Copy link
Collaborator Author

sveinse commented Sep 29, 2025

Being spread a little too thin and slipping the details tells me two things: a) here and now fix is much more valuable than "lets remember to note it later", b) A PR puts a record in the git history which is traceable and will make it to the changelog. List of issues is not. So its important to get an explicit PR for something new. "Explicit is better than implicit." Zen of python

@steinmn
Copy link
Contributor

steinmn commented Sep 29, 2025

Completely forgot about that one myself, so you're in good company in the aquarium 😛

And in the spirit of not trusting myself to remember this tomorrow: #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants