[WIP] Bump rand_core from v0.9 to v0.10.0-rc-2
#842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Nov 6, 2025
Contributor
|
Looks good so far, thank you for doing this! |
Prior to a final stable release of the @RustCrypto dependencies used by the dalek crates, we are going to target `rand_core` v0.10. This updates the `rand` and `rand_core` dependencies as well as the aforementioned @RustCrypto dependencies to be compatible with `rand_core` v0.10, which incurred a few API changes: - `rand_core` no longer includes `OsRng`, so this replaces the `os_rng` features with `getrandom` features (same thing we did for @RustCrypto) which uses the `getrandom` crate directly - For `dev-dependencies` it just migrates straight to `rand`, replacing `rand_chacha` with the `chacha` feature of `rand` (which pulls in `chacha20`), and sourcing `OsRng` from `rand`, its new home (for now)
tarcieri
force-pushed
the
rand_core/v0.10-rc
branch
from
07744fd to
d14e0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to a final stable release of the @RustCrypto dependencies used by the dalek crates, we are going to target
rand_corev0.10.This updates the
randandrand_coredependencies as well as the aforementioned @RustCrypto dependencies to be compatible withrand_corev0.10, which incurred a few API changes:rand_coreno longer includesOsRng, so this replaces theos_rngfeatures withgetrandomfeatures (same thing we did for @RustCrypto) which uses thegetrandomcrate directlydev-dependenciesit just migrates straight torand, replacingrand_chachawith thechachafeature ofrand(which pulls inchacha20), and sourcingOsRngfromrand, its new home (for now)Depends on:
rand_coredependency to v0.10.0-rc-2 zkcrypto/ff#147rand_coredependency to v0.10.0-rc-2 zkcrypto/group#69