romio/daos: better conditionals to build with libdaos.so.0/1 #45
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the conditional compilation logic in the daos adio driver for compiling against libdaos.so.0 (old API) that does not provide a DAOS_API_MAJOR_VERSION preprocessor macro. Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
|
It is TBD if this PR will be landed. Or if instead, the code changes may simply be included in PR 44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the conditional compilation logic in the daos adio
driver for compiling against libdaos.so.0 (old API) that does not
provide a DAOS_API_MAJOR_VERSION preprocessor macro.
Signed-off-by: Kenneth Cain kenneth.c.cain@intel.com
Pull Request Description
Expected Impact
Author Checklist
module: short descriptionand follows good practice