dapr default better devex #214
Conversation
filintod
force-pushed
the
filinto/dapr-default-better-devex
branch
from
7725a5b to
4090c5f
Compare
|
@sicoyle ptal |
| self.wf_runtime_is_running = True | ||
|
|
||
| logger.info("Sleeping for 5 seconds to ensure runtime is started.") | ||
| time.sleep(5) |
There was a problem hiding this comment.
helps with actor runtime not found
There was a problem hiding this comment.
should we rm since i have the open pr upstream and theyre planning to cut 1.16.1 next week
There was a problem hiding this comment.
I'm not sure that will fix that, if there is no app port define won't you still need some time to have the runtime ready?
dapr_agents/llm/dapr/chat.py
Outdated
| dapr_runtime_version = extended_metadata.get("daprRuntimeVersion", None) | ||
| if dapr_runtime_version is not None: | ||
| # Allow only versions >=1.16.0 and <2.0.0 for Alpha2 Chat Client | ||
| if not is_version_supported(str(dapr_runtime_version), ">=1.16.0, <2.0.0"): |
There was a problem hiding this comment.
add "edge" as valid here too pls
| self.wf_runtime_is_running = True | ||
|
|
||
| logger.info("Sleeping for 5 seconds to ensure runtime is started.") | ||
| time.sleep(5) |
There was a problem hiding this comment.
should we rm since i have the open pr upstream and theyre planning to cut 1.16.1 next week
| <details open> | ||
| <summary><strong>Option 1: Using uv (Recommended)</strong></summary> | ||
|
|
||
| <!-- We include setting up the venv as part of the first step to make sure the venv is created and activated before the examples are run.--> |
There was a problem hiding this comment.
the first step was moved up to setup the environment, we probably should add an option in mechanical markdown for SETUP/TEARDOWN
There was a problem hiding this comment.
added this issue in mm repo dapr/mechanical-markdown#38 that I'll try to implement
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
Signed-off-by: Filinto Duran <1373693+filintod@users.noreply.github.com>
filintod
force-pushed
the
filinto/dapr-default-better-devex
branch
from
7ae8c70 to
237d5e7
Compare
Try to avoid needing to set a component_name on DaprChatClient if there is only one
Some information: https://github.com/dapr/dapr-agents/pull/214/files#diff-af44c8a9ee00a1e8c503613a8e0a033597c81dd1ecc35fb4a196d2322152c098R41