Skip to content

Conversation

passuied
Copy link

@passuied passuied commented Sep 27, 2025

Description

  • Add async version of durabletask client
  • Also fixes bug with when_all() and when_any() when passed empty lists

Please note, I'm not 100% sure we shouldn't also create an AsyncTaskHubGrpcWorker as well to avoid mixing sync and async. Though I see TaskHUbGrpcWorker already implements async but runs it in a background thread.

Issue reference
#18
dapr/python-sdk#835

…kHubGrpcClient`

- Added e2e tests

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
fixed dev dependencies

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
@filintod
Copy link

@elena-kolevska do you mind checking on this? it looks good to me. There is no good copyright information in README like in other dapr repos to follow or not, but I guess that would be needed??

Thanks

Copy link
Member

@acroca acroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor naming comment.

Also cleaning dependencies to align protobuf dependencies between grpc-tools and grpcio

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
…s they return successfully.

Added corresponding unit tests for happy path and edge case

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
@passuied passuied requested a review from acroca September 30, 2025 22:33
@elena-kolevska
Copy link
Collaborator

@elena-kolevska do you mind checking on this? it looks good to me. There is no good copyright information in README like in other dapr repos to follow or not, but I guess that would be needed??

Thanks

Yes, we can add the following to new files:

# Copyright (c) The Dapr Authors.
# Licensed under the MIT License.

And we can add the following line in significantly modifed files:

# Copyright (c) 2025 The Dapr Authors.

Added copyright headers on new files

Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WORKFLOW SDK BUG] when_all([]) causes the activity to never complete

4 participants