-
Notifications
You must be signed in to change notification settings - Fork 5
Add async version of durabletask client #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…kHubGrpcClient` - Added e2e tests Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
cf53784
to
f4d8a38
Compare
fixed dev dependencies Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
@elena-kolevska do you mind checking on this? it looks good to me. There is no good copyright information in README like in other dapr repos to follow or not, but I guess that would be needed?? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor naming comment.
Also cleaning dependencies to align protobuf dependencies between grpc-tools and grpcio Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
…s they return successfully. Added corresponding unit tests for happy path and edge case Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Yes, we can add the following to new files:
And we can add the following line in significantly modifed files:
|
Added copyright headers on new files Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
Description
when_all()
andwhen_any()
when passed empty listsPlease note, I'm not 100% sure we shouldn't also create an
AsyncTaskHubGrpcWorker
as well to avoid mixing sync and async. Though I seeTaskHUbGrpcWorker
already implements async but runs it in a background thread.Issue reference
#18
dapr/python-sdk#835