-
Notifications
You must be signed in to change notification settings - Fork 1.2k
darktable.css: Use a darker shade for non active modules. #19708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I prefer this version over all the colored versions I have seen so far. I think it could be a little more darker if this works with dark and darker themes, too. |
830d772 to
5859170
Compare
|
yes to the button, no to the history stack. Just looking at it above I can't even guess what it says unless I put my face against the screen (and then I have to wipe off the nose print ;-D) |
I'll try to only make the button darker not the text. |
|
Is it possible to change the background of the active/inactive module header? I think making the background lighter (along with the lighter button) for inactive might present an easier to notice visual clue. |
5859170 to
589045d
Compare
No, this would not be ok with the different state of the button and it is not consistent with the current design. |
|
For me the on/off button darkening is a clear improvement. Also better than any coloring. |



People have said multiple time that the on/off buttons are hard to distinguidh. Some colored CSS theme have been created based on that.
What about a darker button when not active?
Before:
After:
Tested on dark, darker and gray themes.