Skip to content

Conversation

@TurboGit
Copy link
Member

People have said multiple time that the on/off buttons are hard to distinguidh. Some colored CSS theme have been created based on that.

What about a darker button when not active?

Before:

image

After:

image

Tested on dark, darker and gray themes.

@TurboGit TurboGit added this to the 5.4 milestone Nov 10, 2025
@TurboGit TurboGit added feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't difficulty: trivial some changes in a couple of functions scope: UI user interface and interactions labels Nov 10, 2025
@pehar1
Copy link

pehar1 commented Nov 10, 2025

I prefer this version over all the colored versions I have seen so far. I think it could be a little more darker if this works with dark and darker themes, too.

@TurboGit
Copy link
Member Author

A new version where only the on/off buttons are darker and also handle the disabled module in history:

image image

@TurboGit TurboGit changed the title RFC: darktable.css: Use a darker shade for non active buttons. RFC: darktable.css: Use a darker shade for non active modules. Nov 10, 2025
@wpferguson
Copy link
Member

yes to the button, no to the history stack. Just looking at it above I can't even guess what it says unless I put my face against the screen (and then I have to wipe off the nose print ;-D)

@TurboGit
Copy link
Member Author

yes to the button, no to the history stack. Just looking at it above I can't even guess what it says unless I put my face against the screen (and then I have to wipe off the nose print ;-D)

I'll try to only make the button darker not the text.

@gi-man
Copy link
Contributor

gi-man commented Nov 10, 2025

Is it possible to change the background of the active/inactive module header? I think making the background lighter (along with the lighter button) for inactive might present an easier to notice visual clue.

@TurboGit
Copy link
Member Author

New version of history with only the button changed:

image

@TurboGit
Copy link
Member Author

Is it possible to change the background of the active/inactive module header? I think making the background lighter (along with the lighter button) for inactive might present an easier to notice visual clue.

No, this would not be ok with the different state of the button and it is not consistent with the current design.

@jenshannoschwalm
Copy link
Collaborator

For me the on/off button darkening is a clear improvement. Also better than any coloring.

@TurboGit TurboGit changed the title RFC: darktable.css: Use a darker shade for non active modules. darktable.css: Use a darker shade for non active modules. Nov 11, 2025
@TurboGit TurboGit merged commit 143c9f2 into master Nov 11, 2025
1 check passed
@TurboGit TurboGit deleted the po/button-state branch November 11, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: trivial some changes in a couple of functions feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants