make Parser.Symbol public to make implementation of EntryCallback and ExitCallback possible #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ExitCallback possible
|
@uw4 Could you please take a look? |
|
We're currently busy with other tasks - please stand by |
Happy New Year! I hope you will have a chance to look at my changes; it will help us move forward with using your library. Thanks |
|
@dieu Sorry for the late response. Can you please explain your use case (i.e. why do you need to provide an implementation for the entry / exit callbacks)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Currently, it's impossible to implement
EntryCallbackandExitCallbacksince Parser.Symbol is not public and can't be referenced outsidecom.dashjoin.jsonatapackage.