Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

This PR adds basic S3 file cleanup when the asset that a file is created for/references is deleted. This makes sense today as we only support uploading files in asset documentation, and we use that asset that the file is uploaded to to check permissions for whether a user can view the file that was uploaded or not. So if that asset is deleted, we should also remove the file.

This implementation may change in the future as we extend this file upload feature to more surface areas of the app, but for now I wanted a basic version of it checked in.

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 18.07229% with 68 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../linkedin/metadata/entity/DeleteEntityService.java 0.00% 50 Missing ⚠️
...om/linkedin/metadata/entity/DeleteEntityUtils.java 0.00% 13 Missing ⚠️
...ava/com/linkedin/gms/factory/s3/S3UtilFactory.java 42.85% 3 Missing and 1 partial ⚠️
...gms/factory/entity/DeleteEntityServiceFactory.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (18.07%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 11, 2025

✅ Meticulous spotted 0 visual differences across 967 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit e8cf1d2. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Bundle Report

Changes will increase total bundle size by 9 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.63MB 9 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 9 bytes 19.0MB 0.0%

Files in assets/index-*.js:

  • ./src/app/shared/hooks/useCreateFile.ts → Total Size: 2.11kB

  • ./src/app/shared/hooks/useFileUpload.ts → Total Size: 1.41kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants