fix for #198 #215
Open
fix for #198 #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change indeed fixed the duplicated ID issue. However, later I found out, that switching the language was no longer working correctly, so I rolled it back. Accordingly my PR only fixes the typos. |
|
Oh, I didn't follow that fully from the other PR. Do you have a recollection of how the language was no longer working? |
|
I think the issue was concerning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @ismirsehregal in #198 (comment), a minor fix is made to
R/module-auth.Rto remove the duplicate input ID, and avoid error popups being flashed to the screen on authentication.