Skip to content

make getRecordInfo options optional #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make getRecordInfo options optional #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66505a1
set default value for getRecordInfo options
KonkenBonken Apr 18, 2024
1ad8089
bump npm version
KonkenBonken Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/recorder-react-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"@daybrush/utils": "^1.10.2",
"@scena/react-store": "^0.2.1",
"@scenejs/effects": "^1.0.1",
"@scenejs/recorder": "~0.15.0",
"@scenejs/recorder": "~0.16.0",
"dom-to-image-more": "^2.13.1",
"html-to-image": "^1.11.2",
"react-scenejs": "^2.0.0-beta.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/recorder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scenejs/recorder",
"version": "0.15.0",
"version": "0.16.0",
"description": "Make a movie of CSS animation through Scene.js for browser",
"main": "./dist/recorder.cjs.js",
"module": "./dist/recorder.esm.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/recorder/src/Recorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ export class Recorder extends EventEmitter<{
* Get the information to be recorded through options.
* @sort 1
*/
public getRecordInfo(options: RecordInfoOptions) {
public getRecordInfo(options: RecordInfoOptions = {}) {
const animator = this._animator;
const inputIteration = options.iteration;
const inputDuration = options.duration || 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/render/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@ffmpeg/core": "^0.11.0",
"@ffmpeg/ffmpeg": "^0.11.6",
"@scena/event-emitter": "^1.0.5",
"@scenejs/recorder": "~0.15.0",
"@scenejs/recorder": "~0.16.0",
"@types/puppeteer": "^5.4.5",
"args": "^5.0.1",
"fluent-ffmpeg": "^2.1.2",
Expand Down