Skip to content

build for oem partners #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

build for oem partners #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...ar/lib/delphix-platform/ansible/10-delphix-platform/roles/delphix-platform/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,16 +550,6 @@
regexp: 'disk\/by-id\/wwn-'
replace: 'disk/by-id/wwn/'

#
# Enable CRA for external variants
#
- command: pam-auth-update {{ item }}
with_items:
- --enable challenge-response
- --remove unix
when:
- variant is regex("external-.*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change this to:

when:
 - variant != "external-minimal"
 - variant is regex("external-.*")

as-is, this will disable CRA for the product, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not intend to merge this PR. It was designed to create a one-time build and I posted the PR to make sure that we're not exposing anything of concern to anybody that uses this build.


#
# Increase login timeout to give support more time to interact with CRA via the console.
#
Expand Down