fix graph job not erroring when fetching subs fails #13473
Merged
+25
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In #13463 I tried to make graph jobs error but then complete the submission.
Upon testing I found it did not error, this was because the fetch was lazy and so it was never in the errored state when it was checked.
I fixed this and made a new test that will detect that condition going forward.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Manual test will confirm failures are reported correctly.
Checklist