Skip to content

Conversation

@jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Nov 4, 2025

What are you trying to accomplish?

In #13463 I tried to make graph jobs error but then complete the submission.

Upon testing I found it did not error, this was because the fetch was lazy and so it was never in the errored state when it was checked.

I fixed this and made a new test that will detect that condition going forward.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Manual test will confirm failures are reported correctly.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review November 4, 2025 21:00
@jakecoffman jakecoffman requested a review from a team as a code owner November 4, 2025 21:00
@jakecoffman jakecoffman merged commit ec125e2 into main Nov 5, 2025
158 of 159 checks passed
@jakecoffman jakecoffman deleted the force-fetching-subdependencies branch November 5, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants