Skip to content

Conversation

xavs
Copy link

@xavs xavs commented Aug 25, 2014

Avoid limiting attachments having to be a file in FS, they could be an outputstream generated from the app.

xavs added 3 commits August 25, 2014 11:03
Avoid limiting attachments having to be a file in FS, they could be an outputstream generated from the app.
Updated email builder
straight byte[] as optional way of sending the attachment data
@antony
Copy link
Collaborator

antony commented Aug 26, 2014

Hi @xavs - thanks for this.

Any chance of getting a quick test written for this as well? The codebase is well tested and I don't want that to change.

@rpalcolea rpalcolea changed the base branch from master to 1.x August 18, 2016 15:01
@rpalcolea
Copy link
Collaborator

I just created a 1.x branch to allow users contributions to the Grails 2.x version of the plugin. Anyway, a test for this will be much appreciate it.

@xavs
Copy link
Author

xavs commented Aug 18, 2016

Hey guys, where are the tests in the repo?
I did use this fix for a while, it does work, but that doesn't mean there could be some collateral damage. I'm not having much spare time these days, but I'll try to revise this soon

@rpalcolea
Copy link
Collaborator

Hi @xavs

Under the 1.x branch. You can find them here: https://github.com/desirable-objects/grails-sendgrid/tree/1.x/test

The current master branch contains the newer version for Grails 3.x. The branch 1.x is for the version that works for Grails 1.3.1 > +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants