Skip to content

feat: update onBeforeMint logic to allow direct DEV staking #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: update onBeforeMint logic to allow direct DEV staking #210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e128ef
feat: update onBeforeMint logic to allow direct DEV staking
0xevmtxn Apr 13, 2023
9340e7e
fix(contract): add condition fee checking
0xevmtxn Apr 17, 2023
22d8ea3
Merge remote-tracking branch 'origin/main' into feat-direct-dev-staking
0xevmtxn Apr 18, 2023
3308069
chore(deps): add @uniswap/v3-periphery
0xevmtxn Apr 18, 2023
d994c93
feat: add univ3 pool in simple collections
0xevmtxn Apr 18, 2023
7762c08
feat: add method to use proper quote estimation
0xevmtxn Apr 18, 2023
d9fa0b5
feat: add uniswap v3 libraries with small modifications
May 1, 2023
9e561d3
style: run lint
May 1, 2023
3803a8a
Merge remote-tracking branch 'origin/main' into feat-direct-dev-staking
May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions contracts/SimpleCollections.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,12 @@ contract SimpleCollections is ITokenURIDescriptor, OwnableUpgradeable {
return false;
}

// Always only allow staking via the SwapAndStake contract.
ISwapAndStake.Amounts memory stakeVia = swapAndStake.gatewayOf(
img.gateway
// Fetch the `amount of ETH` the `DEV staked` is equal to.
uint256 equivalentETHStaked = swapAndStake.getEstimatedEthForDev(
_positions.amount
);

// Validate the staking position.
bool valid = img.requiredETHAmount <= stakeVia.input &&
img.requiredETHFee <= stakeVia.fee;
bool valid = img.requiredETHAmount <= equivalentETHStaked;

if (valid) {
stakedAmountAtMinted[_positions.property][id] = _positions.amount;
Expand Down
4 changes: 4 additions & 0 deletions contracts/interfaces/ISwapAndStake.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,9 @@ interface ISwapAndStake {
uint256 fee;
}

function getEstimatedEthForDev(
uint256 devAmount
) external returns (uint256);

function gatewayOf(address _addr) external view returns (Amounts memory);
}