Skip to content

Fix Issues #1 to #5 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix Issues #1 to #5 #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1078ec7
fix nav buttons
petervavrinecz Feb 6, 2025
f0c9079
hide desktop navbar on mobile
petervavrinecz Feb 6, 2025
70b14a1
invert banner image colors
petervavrinecz Feb 6, 2025
7d3666e
modified grid to 2x2
petervavrinecz Feb 6, 2025
3a85278
improve form validation
petervavrinecz Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

<body>
<!-- Navbar -->
<!-- TODO: Fix Issue, Nav Buttons Don't Work (Desktop & Mobile) -->
<nav class="top">
<div class="bar blue card left-align large">
<a
Expand All @@ -22,16 +21,16 @@
title="Toggle Navigation Menu"
><i class="fa fa-bars"></i
></a>
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
<!-- Navbar on medium and large screens -->
<a id="nav-logo" href="#header" class="bar-item button padding-large white">JobSimulator.Dev</a>
<a id="nav-challenges" href="#challenges" class="bar-item button padding-large hover-white hide-small">Browse Challenges</a>
<a id="nav-signup" href="#signup" class="bar-item button padding-large hover-white hide-small">Sign Up</a>
</div>

<!-- Navbar on small screens -->
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
<a id="mobile-nav-challenges" href="#challenges" class="bar-item button padding-large">Browse Challenges</a>
<a id="mobile-nav-signup" href="#signup" class="bar-item button padding-large">Sign Up</a>
</div>
</nav>

Expand Down
13 changes: 8 additions & 5 deletions src/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@ addEventListener("submit", (event) => {

let email = document.getElementById("email").value;

// TODO: Show Correct Status Messages on Signup Form
// 1. successful signup
// 2. empty email
// 3. taken email
// 4. repeat email
if (email === "") {
renderEmailEmptyError();
} else if (usersTable.find(user => user.username === email)) {
renderEmailTakenError();
} else {
renderSuccess();
usersTable.push({ username: email });
}
});

let toggleNav = () => {
Expand Down
5 changes: 2 additions & 3 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ form > span {

#jumbo-image {
max-height: 20rem;
/* TODO: Invert banner colors using CSS */
filter: invert(1);
}

@media (max-width: 600px) {
Expand Down Expand Up @@ -876,8 +876,7 @@ form > span {

#challenge-grid {
display: grid;
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
grid-template-columns: none;
grid-template-columns: 1fr 1fr;
grid-auto-rows: 10rem;
gap: 1rem;
padding-top: 2rem;
Expand Down
Loading