feat: provides parse methods for wifi types #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds parse methods for all WiFi enumeration types to enable bidirectional string-to-enum conversion. It also standardizes constant naming by removing underscores from EncryptionMethod constants.
- Adds reverse lookup maps and parse functions for all WiFi enumeration types (AuthenticationMethod, BSSType, EnabledState, etc.)
- Refactors EncryptionMethod constants to use consistent naming without underscores
- Updates test cases to use the new constant names and adds comprehensive tests for the new parse functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pkg/wsman/cim/wifi/decoder.go | Adds reverse lookup maps and parse functions for all enumeration types, refactors EncryptionMethod constant names |
| pkg/wsman/cim/wifi/decoder_test.go | Updates test cases to use new constant names and adds tests for ParseEncryptionMethod function |
rsdmike
force-pushed
the
wifiParsers
branch
2 times, most recently
from
2e9d709 to
7c5a4a7
Compare
madhavilosetty-intel
approved these changes
Jul 29, 2025
|
🎉 This PR is included in version 2.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.