feat: adds CIRA section to config #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds CIRA (Client Initiated Remote Access) configuration support to the AMT (Active Management Technology) specific configuration section. The change introduces a new CIRA struct with MPS (Management Presence Server) configuration fields and integrates it into the existing AMTSpecific configuration structure.
- Adds a new CIRA configuration struct with MPS-related fields
- Integrates CIRA configuration into the AMTSpecific struct
Comments suppressed due to low confidence (1)
pkg/config/v2.go:127
- [nitpick] The field name 'EnvironmentDetection' is ambiguous. Consider a more descriptive name like 'DetectedEnvironments' or 'SupportedEnvironments' to clarify what this slice contains.
EnvironmentDetection []string `yaml:"environmentDetection"`
graikhel-intel
previously approved these changes
Jul 30, 2025
graikhel-intel
approved these changes
Jul 30, 2025
|
🎉 This PR is included in version 2.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.