Skip to content

fix: unmarshalling SelectorResponse now includes Text data #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix: unmarshalling SelectorResponse now includes Text data #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/wsman/amt/auditlog/message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ func (service Service) ReadRecords(startIndex int) (response Response, err error

err = service.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

response.Body.DecodedRecordsResponse = convertToAuditLogResult(response.Body.ReadRecordsResponse.EventRecords)

return
return response, err
}
54 changes: 27 additions & 27 deletions pkg/wsman/amt/authorization/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ func (as Service) EnumerateUserACLEntries(startIndex int) (response Response, er

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Gets the state of a user ACL entry (enabled/disabled).
Expand All @@ -76,16 +76,16 @@ func (as Service) GetACLEnabledState(handle int) (response Response, err error)

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Returns the username attribute of the Admin ACL.
Expand All @@ -101,16 +101,16 @@ func (as Service) GetAdminACLEntry() (response Response, err error) {

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Reads the Admin ACL Entry status from Intel® AMT. The return state changes as a function of the admin password.
Expand All @@ -126,16 +126,16 @@ func (as Service) GetAdminACLEntryStatus() (response Response, err error) {

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Reads the remote Admin ACL Entry status from Intel® AMT. The return state changes as a function of the remote admin password.
Expand All @@ -151,16 +151,16 @@ func (as Service) GetAdminNetACLEntryStatus() (response Response, err error) {

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Reads a user entry from the Intel® AMT device. Note: confidential information, such as password (hash) is omitted or zeroed in the response.
Expand All @@ -176,16 +176,16 @@ func (as Service) GetUserACLEntryEx(handle int) (response Response, err error) {

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Removes an entry from the User Access Control List (ACL), given a handle.
Expand All @@ -201,16 +201,16 @@ func (as Service) RemoveUserACLEntry(handle int) (response Response, err error)

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Enables or disables a user ACL entry. Disabling ACL entries is useful when accounts that cannot be removed (system accounts - starting with $$) are required to be disabled.
Expand All @@ -226,16 +226,16 @@ func (as Service) SetACLEnabledState(handle int, enabled bool) (response Respons

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Updates an Admin entry in the Intel® AMT device.
Expand All @@ -251,14 +251,14 @@ func (as Service) SetAdminAclEntryEx(username, digestPassword string) (response

err = as.Base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}
18 changes: 9 additions & 9 deletions pkg/wsman/amt/boot/settingdata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,16 @@ func (settingData SettingData) Get() (response Response, err error) {
// send the message to AMT
err = settingData.base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Enumerate returns an enumeration context which is used in a subsequent Pull call.
Expand All @@ -54,16 +54,16 @@ func (settingData SettingData) Enumerate() (response Response, err error) {
// send the message to AMT
err = settingData.base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Pull returns the instances of this class. An enumeration context provided by the Enumerate call is used as input.
Expand All @@ -77,16 +77,16 @@ func (settingData SettingData) Pull(enumerationContext string) (response Respons
// send the message to AMT
err = settingData.base.Execute(response.Message)
if err != nil {
return
return response, err
}

// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

func (settingData SettingData) Put(bootSettingData BootSettingDataRequest) (response Response, err error) {
Expand Down
24 changes: 12 additions & 12 deletions pkg/wsman/amt/environmentdetection/settingdata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ func (sd SettingData) Get() (response Response, err error) {
// send the message to AMT
err = sd.base.Execute(response.Message)
if err != nil {
return
return response, err
}
// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Enumerate returns an enumeration context which is used in a subsequent Pull call.
Expand All @@ -52,15 +52,15 @@ func (sd SettingData) Enumerate() (response Response, err error) {
// send the message to AMT
err = sd.base.Execute(response.Message)
if err != nil {
return
return response, err
}
// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Pull returns the instances of this class. An enumeration context provided by the Enumerate call is used as input.
Expand All @@ -73,15 +73,15 @@ func (sd SettingData) Pull(enumerationContext string) (response Response, err er
// send the message to AMT
err = sd.base.Execute(response.Message)
if err != nil {
return
return response, err
}
// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}

// Put will change properties of the selected instance.
Expand All @@ -99,13 +99,13 @@ func (sd SettingData) Put(environmentDetectionSettingData EnvironmentDetectionSe
// send the message to AMT
err = sd.base.Execute(response.Message)
if err != nil {
return
return response, err
}
// put the xml response into the go struct
err = xml.Unmarshal([]byte(response.XMLOutput), &response)
if err != nil {
return
return response, err
}

return
return response, err
}
Loading
Loading