-
Notifications
You must be signed in to change notification settings - Fork 240
dsl: Introduce abstractions for multi-stage time integrators #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fernanvr
wants to merge
14
commits into
devitocodes:main
Choose a base branch
from
fernanvr:multi-stage-time-integrator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1d830b8
implementation of multi-stage time integrators
fernanvr 7f087b3
Merge remote-tracking branch 'upstream/main' into multi-stage-time-in…
fernanvr 214d882
Return of first PR comments
fernanvr d6c4d4a
Return of first PR comments
fernanvr 78f8a0b
2nd PR revision
fernanvr 1c9d517
2nd PR revision
fernanvr 11db48b
2rd PR, updating tests and suggestions of 2nd PR revision
fernanvr 83dfb04
3rd PR, updating tests and suggestions of 2nd PR revision
fernanvr d47a106
4th PR revision, code refining and improving tests
fernanvr 1f93a45
4th PR revision, code refining and improving tests
fernanvr eea3a52
5th PR revision, one suggestion from EdC and improving tests
fernanvr 11d1429
including two more Runge-Kutta methods and improving tests: checking …
fernanvr 4637ac2
changes to consider coupled Multistage equations
fernanvr ac1da7e
Improvements of the HORK_EXP
fernanvr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
InvalidOperator) | ||
from devito.logger import (debug, info, perf, warning, is_log_enabled_for, | ||
switch_log_level) | ||
from devito.ir.equations import LoweredEq, lower_exprs, concretize_subdims | ||
from devito.ir.equations import LoweredEq, lower_multistage, lower_exprs, concretize_subdims | ||
from devito.ir.clusters import ClusterGroup, clusterize | ||
from devito.ir.iet import (Callable, CInterface, EntryFunction, FindSymbols, | ||
MetaCall, derive_parameters, iet_build) | ||
|
@@ -36,7 +36,6 @@ | |
disk_layer) | ||
from devito.types.dimension import Thickness | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please run the linter ( |
||
__all__ = ['Operator'] | ||
|
||
|
||
|
@@ -327,6 +326,8 @@ def _lower_exprs(cls, expressions, **kwargs): | |
* Apply substitution rules; | ||
* Shift indices for domain alignment. | ||
""" | ||
expressions = lower_multistage(expressions, **kwargs) | ||
|
||
expand = kwargs['options'].get('expand', True) | ||
|
||
# Specialization is performed on unevaluated expressions | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is method a string here, or is it the class for the method? In the latter case, it would remove the need to have the
method_registry
mapper. Furthermore, it would allow you to havemethod.resolve(target, sols_temp)
here, which is tidier