compiler: Fix MPI with CondDim + multiple loc_indices #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioLuporini
added
the
bug-C-minor
FabioLuporini
commented
Aug 1, 2025
devito/ir/clusters/algorithms.py
Outdated
|
|
||
| yield hs, c1 | ||
|
|
||
| def _make_halo_touch(self, hs, c, prefix): |
There was a problem hiding this comment.
the bulk here is the same as before, just moved into its own function
FabioLuporini
commented
Aug 1, 2025
| def process(self, clusters): | ||
| return self._process_fatd(clusters, 1, seen=set()) | ||
|
|
||
| def _derive_halo_schemes(self, c): |
FabioLuporini
force-pushed
the
fix-mpi-t0-t1-conddim
branch
from
64ccb93 to
9991b3a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
=======================================
Coverage ? 78.30%
=======================================
Files ? 248
Lines ? 49678
Branches ? 4376
=======================================
Hits ? 38902
Misses ? 9958
Partials ? 818 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Aug 1, 2025
FabioLuporini
force-pushed
the
fix-mpi-t0-t1-conddim
branch
2 times, most recently
from
511421c to
aec9027
Compare
georgebisbas
approved these changes
Aug 5, 2025
FabioLuporini
force-pushed
the
fix-mpi-t0-t1-conddim
branch
from
aec9027 to
5afbbbc
Compare
FabioLuporini
force-pushed
the
fix-mpi-t0-t1-conddim
branch
from
5afbbbc to
4649f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagged as bug-C-minor because it only pops up in a fairly contrived situation and not flagged by any users...
But still a bug