test: Enhance tests for interaction between deviceid and visible devices #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces, and improve errors for invalid combinations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
==========================================
- Coverage 83.03% 83.01% -0.02%
==========================================
Files 248 248
Lines 50499 50811 +312
Branches 4440 4479 +39
==========================================
+ Hits 41930 42183 +253
- Misses 7807 7860 +53
- Partials 762 768 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return visible_devices[logical_deviceid] | ||
| except IndexError: | ||
| errmsg = (f"A deviceid value of {logical_deviceid} is not valid " | ||
| f"with VISIBLE_DEVICES={visible_devices}. Note that " |
Contributor
There was a problem hiding this comment.
since you're at it, fetch the self.platform and prefix it with CUDA_ or ROCM_ accordingly?
also, did you mean "with" or "within" ?
mloubout
added
API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves errors for invalid combinations.