Fix build for GOARCH=wasm with GOOS=js or GOOS=wasip1 #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for badger-docs canceled.
|
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
Contributor
Author
|
Still relevant |
Contributor
|
@paralin could you rebase the PR on latest |
paralin
force-pushed
the
fix-wasm
branch
2 times, most recently
from
126017e to
1956019
Compare
Contributor
Author
|
@mangalaman93 I rebased it. The tests do not pass since mmap fails on wasm. I think there would need to be conditional logic to not use mmap on wasm / js for this to actually be usable. But at least it compiles on these platforms now, with stubs. |
Fixes the following build failures: GOOS=js GOARCH=wasm go build ./... GOOS=wasip1 GOARCH=wasm go build ./... Depends on: dgraph-io/ristretto#375 Signed-off-by: Christian Stewart <christian@aperture.us>
Contributor
Author
|
Rebased again. I think this is still good to merge, even though js does not work properly, at least it builds cleanly. |
mangalaman93
approved these changes
Nov 28, 2024
mangalaman93
requested changes
Dec 1, 2024
Contributor
mangalaman93
left a comment
mangalaman93
left a comment
There was a problem hiding this comment.
Thank you for the PR, just two minor comments.
mangalaman93
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following build failures:
GOOS=js GOARCH=wasm go build ./...
GOOS=wasip1 GOARCH=wasm go build ./...
Depends on: dgraph-io/ristretto#375