Skip to content

Conversation

@xqqp
Copy link
Contributor

@xqqp xqqp commented Nov 11, 2025

Zero currently has several issues related to shutdown:

  • remove enterprise license completely from dgraph #9367 removed a call to updateEnterpriseState() without decreasing the wait group counter. This makes zero wait indefinitely, or exit with a return code other than zero after it has been forced to terminate.
  • Pools never get shutdown, which keeps the pool's health check alive, resulting in logs with connection failures.
  • The pool health check uses time.Sleep, so even if pools would get shutdown, the shutdown would be delayed by the remaining sleep duration.

This PR sets the appropriate wait group counter, implements a function which removes pools on shutdown and switches from time.Sleep to time.Ticker in the health check.

@xqqp xqqp force-pushed the fix_zero_shutdown branch from ee56b98 to 9334cda Compare November 11, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant