BUG/CITE-212: Adding search endpoint with collections #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Apr 10, 2024
|
|
||
| if (group == null) { | ||
| logger.error("User " + user.getUsername() + " does not have access to group " + zoteroGroupId); | ||
| return "error/404"; |
There was a problem hiding this comment.
if the user doesn't have access they should get a 403.
| breadCrumbs.add(new BreadCrumb(group.getName(), BreadCrumbType.GROUP, group.getGroupId() + "", group)); | ||
| Collections.reverse(breadCrumbs); | ||
| model.addAttribute("breadCrumbs", breadCrumbs); | ||
| return "auth/group/items"; |
There was a problem hiding this comment.
that looks like a lot of duplicate code; should be more DRY.
…e SearchItemsDataDto class
…ew name to returning JSON data
jdamerow
requested changes
Aug 27, 2025
| foundCitations.add(mapReference(r)); | ||
| }); | ||
| return new ResultPage(foundCitations, results.getTotalElements(), results.getTotalPages()); | ||
| } |
There was a problem hiding this comment.
isn't this pretty much the same code as in the search method above? DRY
|
|
||
| Gson gson = new Gson(); | ||
| return gson.toJson(searchItemsData, SearchItemsDataDto.class); | ||
| } |
There was a problem hiding this comment.
same here, looks like pretty much the same as the above method. I actually doubt you'll need two separate methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
https://diging.atlassian.net/browse/CITE-212
... Put ticket description here and add link to ticket ...
Are there any other pull requests that this one depends on?
Anything else the reviewer needs to know?
... describe here ...