Skip to content

Conversation

jophals
Copy link
Contributor

@jophals jophals commented Jun 7, 2024

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

Users should be able to include external links on their slides, which will be visible on the public page.

Anything else the reviewer needs to know?

This is my first Java PR!

@jdamerow
Copy link
Member

This needs some UI work. There is too much white space on the right and the input fields are too short.
image

The external links should probably be on top before the content blocks, so the user doesn't have to scroll. And the layout should be better (actually heading, showing of the whole url, etc).
image

@jdamerow jdamerow closed this Mar 26, 2025
UI issues, cleaned up some unnecessary css styling, and fixed module
links block UI issues
@jophals jophals reopened this Mar 31, 2025
@jdamerow
Copy link
Member

jdamerow commented Apr 2, 2025

Resolve conflicts please

@jdamerow jdamerow closed this Apr 2, 2025
@jophals jophals reopened this Apr 16, 2025
@jdamerow
Copy link
Member

jdamerow commented Jun 4, 2025

Make it so, Jenkins.

@jdamerow
Copy link
Member

jdamerow commented Jun 4, 2025

Clicking the button that says "Add External Link" doesn't do anything. I believe it's because of a syntax error (that shows in the console).

Also, I'm confused about where the "External Resources" block would show up. Sometimes it is on top, sometimes at the bottom and sometimes in between?
image

And lastly, while I don't know how it looks like when there are links, the heading looks too off to the side:
image

@jdamerow jdamerow closed this Jun 4, 2025
fixed external links layout issues in slide.html and module.html
@jophals jophals reopened this Jun 5, 2025
@jdamerow
Copy link
Member

Resolve conflicts please

@jdamerow jdamerow closed this Jun 17, 2025
@jophals jophals reopened this Jun 20, 2025
@jdamerow
Copy link
Member

jdamerow commented Aug 6, 2025

Make it so, Jenkins.

@jdamerow
Copy link
Member

jdamerow commented Aug 6, 2025

The "External Resources" block is cut off at the bottom (there should be two links but only one is visible). Also, the heading shows up even if there are no links.
image

@jdamerow jdamerow closed this Aug 6, 2025
@Girik1105 Girik1105 reopened this Oct 3, 2025
@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow
Copy link
Member

The links should be in the color scheme of the rest of the exhibition.

@jdamerow
Copy link
Member

Also, there seem to be changes in here that make the branching points disappear:
image

@jdamerow jdamerow closed this Oct 10, 2025
@Girik1105 Girik1105 reopened this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants