Story/vspc 275 #353
Open
Story/vspc 275 #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
images, fixed cancel button, fixed edit button
default images, added file upload constraints
default image styling, upgraded tika and commons-io dependencies, etc.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Resolve conflicts please |
|
Make it so, Jenkins. |
jdamerow
requested changes
Jun 17, 2025
| Tika tika = new Tika(); | ||
| System.out.println("HERE2"); | ||
| String contentType = tika.detect(image); | ||
| System.out.println("CONTENT TYPE: " + contentType); |
| return "redirect:/staff/exhibit/config"; | ||
| } else { | ||
| setter.accept(exhibition, defaultImage); | ||
| exhibition = (Exhibition) exhibitionManager.storeExhibition(exhibition); |
| exhibition = (Exhibition) exhibitionManager.storeExhibition(exhibition); | ||
| attributes.addAttribute("exhibitId", exhibition.getId()); | ||
| attributes.addAttribute("alertType", "success"); | ||
| attributes.addAttribute("message", "Successfully Saved!"); |
| attributes.addAttribute("showAlert", "true"); | ||
| } else { | ||
| deleteDefautImageMethod.run(); | ||
| exhibition = (Exhibition) exhibitionManager.storeExhibition(exhibition); |
There was a problem hiding this comment.
same here, no casting necessary
| return ResponseEntity.badRequest().body(errorMessage); | ||
| } else { | ||
| disableDefautImageMethod.run(); | ||
| exhibition = (Exhibition) exhibitionManager.storeExhibition(exhibition); |
There was a problem hiding this comment.
neither casting nor assigning the return value to a variable seems necessary
cancel button not disabling after default images are deleted, fixed casting of Exhibition type in controller, added javadoc for default image delete endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
Modifications to default images for space, module, and external links
It seems like right now, only certain file types can be used (e.g. png, maybe jpeg, gif?), when uploading a new default image in the settings page, the user should only be able to upload accepted file types
it needs to be possible to use svgs
after an image has been uploaded, instead of showing the filename, it should show the filename and a thumbnail of the image
The button “Change Default XXX Link Image” should just be an icon with a hover text
It should be possible to disable the default image to go back to the original icon (so when it’s disabled, it uses the little walking man icon, if it’s enabled it uses the uploaded image).
All these apply to all three default images.
VSPC-275
Anything else the reviewer needs to know?