Skip to content

Conversation

Girik1105
Copy link

@Girik1105 Girik1105 commented Aug 28, 2025

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Adding new references to a slide issues

  1. New Reference button should be an icon instead of a button
  2. Title should be in bold and description should be below it in appropriate format
  3. Fix misaligned delete buttons

VSPC-277

Anything else the reviewer needs to know?

... describe here ...

@diging-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@diging-jenkins
Copy link

Can one of the admins verify this patch?

@jdamerow
Copy link
Member

Make it so, Jenkins.

@jdamerow
Copy link
Member

  • the button to add a new reference should be just an icon (no button)
  • not sure what's going on, but when I double-click on the reference block, it disappears and the pop up appears. But when I click submit, there are just errors.
image
  • after I created a new blibliography block and added a reference, when I try to edit the bibliography block it shows wrong data:
image

but should be:
image

@jdamerow jdamerow closed this Oct 10, 2025
import java.util.regex.Matcher;
import java.util.regex.Pattern;

public class CitationFormatter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this class used in this pr?

@Girik1105 Girik1105 reopened this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants