Feature/multi level includes #287
Conversation
BREAKING CHANGE: remove "requestedIncludes" option This option should not handle the way this adapter serialize the resources, if there is embedded resources, even if they do not appear in this option, recommended behavior is to have them in the include property as well. Security consideration: nested includes were previously not handled, it is now the case, like in the loopback documentation, you need to ensure it is secured your side.
|
@digitalsadhu some feedback ? |
|
if you make a call with relationship like:
and that the ressource linked don't existe we have a error. Should be catch it. |
|
@Tronix117 I'm afraid I don't have time to get my head back into this project. I'm thinking also with the new version of Loopback being a very major breaking change this project might naturally reach an end of life before too long as I won't be attempting to port anything. I'm happy for you to merge PRs as you see fit and continue maintenance if you have the time. |
|
That’s what I though, from our side we are using it on a big production project and forme time to time we have some evolutions to push. I will do what you say, is npm publishing also fully automatic ? |
This PR allows to have nested includes.
Exemple:
will retrieve all comments, as well as the author of each comments
I also removed the unecessary "requestedIncludes" option.
This option should not handle the way this adapter serialize the resources, if there is embedded resources, even if they do not appear in this option, recommended behavior is to have them in the include property as well.
Security consideration: nested includes were previously not handled, it is now the case, like in the loopback documentation, users need to ensure it is secured their side, like they do when using loopback without JSONApi.