对比本项目与 RFC 8555 出入的地方 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaohuilam
commented
Jul 30, 2019
| */ | ||
| class AuthorizeCommand extends AbstractCommand | ||
| { | ||
| use KeyOptionCommandTrait; |
| ->setDefinition([ | ||
| new InputOption('solver', 's', InputOption::VALUE_REQUIRED, 'The type of challenge solver to use (available: http, dns, route53)', 'http'), | ||
| new InputArgument('domains', InputArgument::IS_ARRAY | InputArgument::REQUIRED, 'List of domains to ask an authorization for'), | ||
| new InputOption('country', null, InputOption::VALUE_REQUIRED, 'Your country two-letters code (field "C" of the distinguished name, for instance: "US")'), |
| $solver = $solverLocator->get($solverName); | ||
| $this->debug('Solver found', ['name' => $solverName]); | ||
|
|
||
| $alternativeNames = $domains; |
| throw $e; | ||
| } | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
挪到 Trait 和 initializeOrder 方法共用
| $client = $this->getClient(); | ||
| $domains = array_unique(array_merge([$domain], $domainConfig['subject_alternative_names'])); | ||
|
|
||
|
|
src/Core/AcmeClient.php
Outdated
| { | ||
| Assert::allStringNotEmpty($domains, 'requestOrder::$domains expected a list of strings. Got: %s'); | ||
|
|
||
| $humanText = ['-----BEGIN CERTIFICATE REQUEST-----', '-----END CERTIFICATE REQUEST-----']; |
| $response['url'], | ||
| $response['token'], | ||
| $response['token'].'.'.$base64encoder->encode($this->getHttpClient()->getJWKThumbprint()) | ||
| isset($response['filecontent']) ? $response['filecontent'] : ($response['token'].'.'.$base64encoder->encode($this->getHttpClient()->getJWKThumbprint())), |
Author
There was a problem hiding this comment.
因为 trustocean (comodoca) 的验证路径/文件名/内容不一致. 特意加上的补充参数
| { | ||
| return sprintf( | ||
| '/.well-known/acme-challenge/%s', | ||
| $authorizationChallenge->getPath() ? ($authorizationChallenge->getPath() . '%s') : '/.well-known/acme-challenge/%s', |
Author
There was a problem hiding this comment.
/.well-known/acme-challenge/ => /.well-known/pki-validation/
|
|
||
| public function delete($path) | ||
| { | ||
| return; |
Author
There was a problem hiding this comment.
keep un-deleted. because when program run here, comodo is not verified for certain yet.
| * @param string $filecontent | ||
| */ | ||
| public function __construct($domain, $status, $type, $url, $token, $payload) | ||
| public function __construct($domain, $status, $type, $url, $token, $payload, $path = null, $verifyurl = null, $filecontent = null) |
Adding Gandi.Net DNS solver class
Adding Gandi.Net DNS solver class
…-solver-aliyun
Feat solver aliyun
Fix test and add php 7.4
Added orderNotReady error type
Fix the wrong return type
Split Sign and Request
Fix getIssuerCertificate return type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.